-
Notifications
You must be signed in to change notification settings - Fork 155
docs(idempotency): add idempotency doc for CachePersistenceLayer
#3937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(idempotency): add idempotency doc for CachePersistenceLayer
#3937
Conversation
…table creation instructions
…tency documentation
… in idempotency documentation
…ency documentation
…of idempotency documentation
CachePersistenceLayer
CachePersistenceLayer
Hi @arnabrahman, thank you for the PR! I'll review it later today/tomorrow morning max |
I have started reviewing the PR and I wanted to rearrange a couple sections here & there, but I need a bit more time. I'll continue later today. |
…ws-lambda-powertools-typescript into 3194-redis-idempotency-doc
|
Hey folks, I made a couple of commits to the PR to update the structure and flow to accommodate the new provider and avoid duplication as much as possible. I need both of your reviews today, if possible @leandrodamascena & @am29d. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I copied some changes and will update the Python documentation with them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
CachePersistenceLayer
docs have been added to idempotency.Changes
CachePersistenceLayer
.One thing I couldn't make it work is the sub-sections. For example, Python doc has subsections of Redis (https://docs.powertools.aws.dev/lambda/python/latest/utilities/idempotency/#redis-database). I am not sure what I am missing here.
Issue number: #3914
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.